[PATCH] D39508: [ubsan] lit changes for lld testing, future lto testing.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 16:22:09 PST 2017


vitalybuka added inline comments.


================
Comment at: test/ubsan/lit.common.cfg:68
+  config.unsupported = True
+
+def build_invocation(compile_flags):
----------------
lebedev.ri wrote:
> eugenis wrote:
> > This code should be shared between cfi/ubsan/asan/msan/sanitizer_common. Please move as much of it as possible one level up.
> > 
> Could you please clarify, do you mean to move `build_invocation()` into `test/lit.common.cfg`, or the variables?
> Moving the function seemed cleaner, but if i do that, i get `NameError: name 'build_invocation' is not defined`, so i'm most likely missing something...
> `
I think it's about moving entire use lld and lto stuff from ubsan to parent dir so all sanitizers can use it


Repository:
  rL LLVM

https://reviews.llvm.org/D39508





More information about the llvm-commits mailing list