[PATCH] D39393: [asan] Use dynamic shadow on 32-bit Android.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 16:08:53 PST 2017


eugenis added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_linux.cc:99
+  uptr granularity = GetMmapGranularity();
+  uptr alignment = granularity * 8;
+  uptr left_padding = granularity;
----------------
vitalybuka wrote:
> why do you need to *8 here?
I had the same question a while ago :)
Because shadow gap  start is calculated as shadow(shadow_start), and needs to be page-aligned, so shadow-start needs to be 8 page aligned.


https://reviews.llvm.org/D39393





More information about the llvm-commits mailing list