[PATCH] D22792: VecClone Pass

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added inline comments.


================
Comment at: include/llvm/Analysis/VectorVariant.h:34-37
+#define STRIDE_KIND 's'
+#define LINEAR_KIND 'l'
+#define UNIFORM_KIND 'u'
+#define VECTOR_KIND 'v'
----------------
mmasten wrote:
> fpetrogalli wrote:
> > We will have to support OpenMP 4.5 linear modifiers, which are rendered as 2-char tokens in the mangled names. Woudn't it better to avoid #defines of chars and instead use enums inside the VectorKind class?
> Ok, I can change this to an enum inside the VectorKind class. I don't have a patch ready for the LoopVectorize part, but I will prepare one and put it up for review in the next few days. I also have a patch for clang that enables the "vector-variants" attribute support.
> Ok, I can change this to an enum inside the VectorKind class.

Thank you.

> I don't have a patch ready for the LoopVectorize part, but I will prepare one and put it up for review in the next few days.

That sounds great, thanks!

> I also have a patch for clang that enables the "vector-variants" attribute support.

Clang is already generating the list of mangled vector names as string attributes. I believe that you  need to rearrange the code so that strings get produced in the vector-variants attribute.





https://reviews.llvm.org/D22792