[llvm] r317462 - Revert "adding a pattern for broadcastm"

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 6 02:53:17 PST 2017


On Mon, Nov 6, 2017 at 10:48 AM, Jina Nahias via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: jina.nahias
> Date: Sun Nov  5 23:48:58 2017
> New Revision: 317462
>
> URL: http://llvm.org/viewvc/llvm-project?rev=317462&view=rev
> Log:
> Revert "adding a pattern for broadcastm"
>
> This reverts commit r317457.
Please write more understandable commit messages.
The part that is missing here is *why* the revert is happening.

> Change-Id: If07f1fca1e3453d16c1dac906e87768661384e91
>
> Modified:
>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=317462&r1=317461&r2=317462&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sun Nov  5 23:48:58 2017
> @@ -6751,8 +6751,8 @@ static SDValue lowerBuildVectorAsBroadca
>
>    // Attempt to use VBROADCASTM
>    // From this paterrn:
> -  //  a. t0 = (zext_i64 (bitcast_i8 v2i1 X))
> -  //  b. t1 = (build_vector t0 t0)
> +  // a. t0 = (zext_i64 (bitcast_i8 v2i1 X))
> +  // b. t1 = (build_vector t0 t0)
>    //
>    // Create (VBROADCASTM v2i1 X)
>    if (Subtarget.hasCDI() && (VT.is512BitVector() || Subtarget.hasVLX())) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list