[PATCH] D36311: [ThinLTO] Add GraphTraits for FunctionSummaries

[Charles Saternos via Phabricator via llvm-commits]

ncharlie marked an inline comment as done.
ncharlie added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:119
+
+inline bool operator!=(ValueInfo &A, ValueInfo &B) {
+  assert(A.Ref && B.Ref && "Need ValueInfo with non-null Ref to compare GUIDs");
----------------
tejohnson wrote:
> I see you have both const and non-const parameter versions of operator== and operator<, but only the non-const parameter version of operator!=. Why is that? Also, since ValueInfo::getGUID is const, I would think you should be able to have only a single version of each operator overload, all taking const ValueInfo.
OK - it works without the non-const operators, so I removed them.


https://reviews.llvm.org/D36311