[PATCH] D38918: Update successor after branch relaxation in ARM

Fri Nov 3 17:10:10 PDT 2017

sabuasal added a comment.

In https://reviews.llvm.org/D38918#900603, @rovka wrote:

> In https://reviews.llvm.org/D38918#899993, @sabuasal wrote:
>
> > I only cared about not having the Dest BB as a successor because it might cause scheduling issues and\or labels not being emitted, having extra successor wont.
>
>
> Do you have an example that you could add as a MIR test for this patch? (If you get stuck parsing MIR constant pools, it's ok to pass IR through llc and just -stop-after this pass)

Unfortunately I don't. I found this in a n out of tree that has modification to ARMConstant Island. What I can do is look at existing test cases and see if I can show the problem in the successor information.

> I think you should make sure this is true (i.e. check that DestBB is not used by any of the other terminators in SplitBlock).

Hmm, ok

Repository:
  rL LLVM

https://reviews.llvm.org/D38918