[PATCH] D39570: [SimplifyCFG] When merging conditional stores, don't count the store we're merging against the PHINodeFoldingThreshold

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 11:45:02 PDT 2017


craig.topper added a comment.

This had no affect on the binary output for any of the benchmarks we ran on trunk.

I only noticed this because one of our internal branches has diverged from community and changed the PHINodeFoldingThreshold from 2 to 1 (I wasn't involved in why that change was made in our branch). This lower threshold causes us to miss cases like merge-cond-store-2.ll despite the fact that it is if convertible with the threshold of 1 after the store is removed.


https://reviews.llvm.org/D39570





More information about the llvm-commits mailing list