[PATCH] D39592: [ARM|GlobalISel] : Adding legalizer tests for Thumb
Diana Picus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 3 08:52:30 PDT 2017
rovka added a comment.
I think it would be simpler to add a RUN line to the existing test (you can rename it to just legalizer.mir if you think the current name would be misleading).
It's ok to have separate tests for ARM vs Thumb instruction selection (*), since there would be more differences there, but I think for simple passes like the legalizer and reg bank select it's easier to follow if we keep them together in the same file.
(*) Alternatively, we can split up the instruction selection tests into smaller chunks and make them mixed ARM/Thumb if it turns out to be easier to read that way.
https://reviews.llvm.org/D39592
More information about the llvm-commits
mailing list