[PATCH] D39459: Rename SymbolBody -> Symbol.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 3 00:36:17 PDT 2017


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D39459#914495, @ruiu wrote:

> Sorry Geroge, but I completely disagree with you. Renaming variables needs human judgement, and mixing it with a mechanical change is a bad idea. We really should submit this first and then rename variables in follow-up patches.
>
> Making a variable renaming change prior to submitting this change doesn't make sense because you can easily get the idea what it would look like. Actually creating a patch just increases the amount of human labor work because I would need to maintain it during review, and it would be painful as it would conflict with a lot of other patches.
>
> Please do not overthink about this patch. We really don't need any clever planning at the moment.


Ok. Probably I misunderstood the idea of this review. So if I correctly understand it now it was to show how renaming from `SymbolBody` to `Symbol` generally looks like in code.
New naming looks much better to me, so I would land it if looks OK for other reviewers.


https://reviews.llvm.org/D39459





More information about the llvm-commits mailing list