[PATCH] D39554: [globalisel][tablegen] Skip src child predicates

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 2 11:04:16 PDT 2017


dsanders added a comment.

LGTM. This must have been missed because they're genuinely operands. A lot of the predicates (particularly those on imm and fpimm) are on operators even though they look like operands.

In https://reviews.llvm.org/D39554#913999, @rovka wrote:

> Sorry about the indirect test, but it's a bit difficult to test directly since this is restricting functionality rather than adding it. Are we interested in having tests for failed imports? I haven't seen any, but I may have missed them...


We don't have any at the moment but I think it makes sense to have them for PatLeaf/ComplexPattern and other things where failing to import is the right thing to do. I don't think we should add them for the cases where it's failing because we haven't implemented something yet


https://reviews.llvm.org/D39554





More information about the llvm-commits mailing list