[PATCH] D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file.

[Mitch Phillips via Phabricator via llvm-commits]

hctim added inline comments.


================
Comment at: lib/Support/SpecialCaseList.cpp:137
+    if (I->empty() || I->startswith("#")) {
+      ++LineNo;
       continue;
----------------
vlad.tsyrklevich wrote:
> Doesn't the loop already handle this?
Too right. There is still a latent bug however - llvm::SplitString culls blank lines from the output vector, so it was generating the wrong line numbers for anything following a blank line.

I've fixed this up and made sure that a unit test is there that catches both these cases.


https://reviews.llvm.org/D39485