[PATCH] D39480: Include GUIDs from the same module when computing GUIDs that needs to be imported.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 1 11:40:47 PDT 2017


danielcdh marked an inline comment as done.
danielcdh added inline comments.


================
Comment at: test/Transforms/SampleProfile/function_metadata.ll:36
+; to foo_available.
+; CHECK: ![[ENTRY_TEST_LIVENESS]] = !{!"function_entry_count", i64 1, i64 4005816710939881937, i64 6699318081062747564}
 
----------------
tejohnson wrote:
> I think you also need to add a second module to test for the A.c:foo() ->(direct or indirect)-> B.c:bar() ->(indirect)-> A.c:baz() case.
foo is not defined in this module, so in this new test it is A.c:test_liveness() ->direct-> B.c:foo() -> (indirect or direct) -> A.c: foo_available().


https://reviews.llvm.org/D39480





More information about the llvm-commits mailing list