[PATCH] D39415: [ARMISelLowering] Better handling of NEON load/store for sequential memory regions

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

Hi,

I tried to give this a run [1] on top of r317072  on an NVIDIA TK1 (Cortex-A15) and I'm getting some failures in the test-suite (in 42 of the benchmarks) along the lines of [2]. I think we should fix those before worrying about performance numbers...

Let me know if you have trouble reproducing these results.

Thanks,
Diana

[1] With these flags: sandbox/bin/python sandbox/bin/lnt runtest test-suite --sandbox sandbox --test-suite test-suite --cc $LLVM_BLD/bin/clang --cxx $LLVM_BLD/bin/clang++ --use-lit $LLVM_BLD/bin/llvm-lit --cppflags '-O3 -mcpu=cortex-a15 -fomit-frame-pointer' --threads=1 --build-threads=4 --use-perf=all --run-under 'taskset -c 0' --benchmarking-only --exec-multisample=3

[2] clang-6.0: llvm/include/llvm/Support/Casting.h:106: static bool llvm::isa_impl_cl<llvm::ConstantSDNode, const llvm::SDNode *>::doit(const From *) [To = llvm::ConstantSDNode, From = const llvm::SDNode *]: Assertion `Val && "isa<> used on a null pointer"' failed.
Stack dump:
0.      Program arguments: build/bin/clang-6.0 -cc1 -triple armv7-unknown-linux-gnueabihf -emit-obj -disable-free -main-file-name ffbench.c -mrelocation-model static -mthread-model posix -fmath-errno -masm-verbose -mconstructor-aliases -fuse-init-array -target-cpu cortex-a15 -target-feature -crc -target-feature +dsp -target-feature -ras -target-feature -dotprod -target-feature +hwdiv-arm -target-feature +hwdiv -target-abi aapcs-linux -mfloat-abi hard -fallow-half-arguments-and-returns -dwarf-column-info -debugger-tuning=gdb -coverage-notes-file sandbox/test-2017-11-01_11-50-24/SingleSource/Benchmarks/Misc/CMakeFiles/ffbench.dir/ffbench.c.gcno -resource-dir build/lib/clang/6.0.0 -D NDEBUG -internal-isystem /usr/local/include -internal-isystem build/lib/clang/6.0.0/include -internal-externc-isystem /usr/include/arm-linux-gnueabihf -internal-externc-isystem /include -internal-externc-isystem /usr/include -O3 -Werror=date-time -w -fdebug-compilation-dir sandbox/test-2017-11-01_11-50-24/SingleSource/Benchmarks/Misc -ferror-limit 19 -fmessage-length 0 -fno-signed-char -fobjc-runtime=gcc -fdiagnostics-show-option -vectorize-loops -vectorize-slp -o CMakeFiles/ffbench.dir/ffbench.c.o -x c test-suite/SingleSource/Benchmarks/Misc/ffbench.c

1. <eof> parser at end of file
2. Code generation
3. Running pass 'Function Pass Manager' on module 'test-suite/SingleSource/Benchmarks/Misc/ffbench.c'.
4. Running pass 'ARM Instruction Selection' on function '@fourn'

clang-6.0: error: unable to execute command: Aborted
clang-6.0: error: clang frontend command failed due to signal (use -v to see invocation)


Repository:
  rL LLVM

https://reviews.llvm.org/D39415