[PATCH] D39267: [GISel]: Change Legalization from top down to bottom up + DCE

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 1 04:26:27 PDT 2017


aemerson added a comment.

Hi Aditya,

I now think this approach is ok to continue with, given the constraints of the MIR type system about needing artifact clean ups as a necessity. I'd also eventually like to see these renamed into something else to make it clear they're distinct from "optimization" combines.

We'll also likely need to have an API to allow later passes to invoke legalization, such as the later GI combiner(s), unless we restrict them to always create legal operations. To do that I think we'll need to refactor the code from this patch into another helper (or the existing LegalizerHelper).

Cheers,
Amara


https://reviews.llvm.org/D39267





More information about the llvm-commits mailing list