[PATCH] D38687: [ELF] Make section order rely on explicit member

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Is my understanding correct that if you check in https://reviews.llvm.org/D38687, you don't need this and https://reviews.llvm.org/D38361?

I thought about all these patches carefully, and I'm leaning towards https://reviews.llvm.org/D38687 because it is by far simple, doesn't need a new member in any class, and it is becoming more in line with other code that uses section offsets. Section offsets used to be computed only once, and once they are set, they would never change. The situation quickly changed because of linker scripts and range extension thunks. In particular, in order to implement the range extension, we need to reassign offsets until they converge. So, section offsets are no longer computed-once value in any sense. So, it started feeling more natural to use section offsets than before.


https://reviews.llvm.org/D38687