[PATCH] D39460: [ELF] NFC: Remove unnecessary function call

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 31 10:14:38 PDT 2017


jhenderson created this revision.
Herald added a subscriber: emaste.

StringTableSection does not implement postThunkContents, so calling it on these sections is pointless (it calls an empty virtual function), and we can remove it.


https://reviews.llvm.org/D39460

Files:
  ELF/Writer.cpp


Index: ELF/Writer.cpp
===================================================================
--- ELF/Writer.cpp
+++ ELF/Writer.cpp
@@ -1365,7 +1365,7 @@
     Sec->finalize<ELFT>();
 
   // createThunks may have added local symbols to the static symbol table
-  applySynthetic({InX::SymTab, InX::ShStrTab, InX::StrTab},
+  applySynthetic({InX::SymTab},
                  [](SyntheticSection *SS) { SS->postThunkContents(); });
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39460.121007.patch
Type: text/x-patch
Size: 436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171031/f8a1a227/attachment.bin>


More information about the llvm-commits mailing list