[PATCH] D39088: [AArch64][SVE] Asm: Replace 'IsVector' by 'RegKind' in AArch64AsmParser (NFC)

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2589
   Operands.push_back(
-      AArch64Operand::CreateReg(Reg, true, S, getLoc(), getContext()));
+      AArch64Operand::CreateReg(Reg, RegisterKind, S, getLoc(), getContext()));
+
----------------
fhahn wrote:
> fhahn wrote:
> > Any reason for not passing `RegKind::NeonVector` directly here? It seems like RegisterKind is not used anywhere else around here.
> Do we need the RegisterKind variable? Doesn't look like it is used somewhere else.
I thought I had addressed it in my previous patch, but I must have missed it. Please see updated patch.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:1909
       return 0;
+
     // set RegNum if the match is the right kind of register
----------------
fhahn wrote:
> nit: unrelated whitespace change
I don't feel strongly about it, but I think it improves readability.


https://reviews.llvm.org/D39088