[PATCH] D38693: [SLP] Consider extractelements as shuffles iff they have the same type/parent etc.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

In https://reviews.llvm.org/D38693#910154, @RKSimon wrote:

> I must say, this patch gets incredibly confusing - TEK_EEShuffle sometimes gets treated like a gather, and other times as a vectorization - it's almost never referenced directly.


Because this is neither the gathering, not the vectorization, but something different. We should not gather instructions and should not vectorize them, just merge them as shuffle.



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:741
       MustGather.insert(VL.begin(), VL.end());
     }
 
----------------
RKSimon wrote:
> Why don't you handle TEK_EEShuffle?
Because for this kind of tree entry we should not do anything - neither gather the items, nor mark them as vectorized, because instead we just merge them into a shuffle


https://reviews.llvm.org/D38693