[PATCH] D37580: Add Position Independent Pages (PIP) relocation model

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I've got a few comments on some of the later patches, as this is the first in the series I just thought I'd mention that, as far as I know, adding llvm-commits as a subscriber after the initial creation is not sufficient for the mailing list to get any updates. I think the usual advice is to abandon the existing reviews and start new ones with llvm-commits subscribed. I'd also suggest adding a link to your llvm-dev post http://lists.llvm.org/pipermail/llvm-dev/2017-June/113794.html to at least one of the reviews as it isn't possible to understand without it. Some of the descriptions of later reviews are quite terse, especially for the backend changes that could do with some more description on why you've made the changes that you would like to make.

I've no specific comments on this patch.


https://reviews.llvm.org/D37580