[PATCH] D39132: [llvm-objcopy] Fix bug in how segment alignment was being handled

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/check-addr-offset-align.test:2-3
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy -O binary %t %t2
+# RUN: llvm-readobj -program-headers %t | FileCheck %s
+
----------------
Umm... reading this again, and I realise now that the test is actually testing yaml2obj, not llvm-objcopy!

You are using binary output to %t2, but then using readobj to check %t, which is the output of yaml2obj!

Also, there should really be test cases for both ELF and binary output format cases, since this change affects both.


Repository:
  rL LLVM

https://reviews.llvm.org/D39132