[PATCH] D39271: Object: Move some code from ELF.h into ELF.cpp.

[Rafael Avila de Espindola via llvm-commits]

Peter Collingbourne via Phabricator <reviews at reviews.llvm.org> writes:

>
> Index: llvm/tools/llvm-readobj/ELFDumper.cpp
> ===================================================================
> --- llvm/tools/llvm-readobj/ELFDumper.cpp
> +++ llvm/tools/llvm-readobj/ELFDumper.cpp
> @@ -1356,8 +1356,11 @@
>  void ELFDumper<ELFT>::parseDynamicTable(
>      ArrayRef<const Elf_Phdr *> LoadSegments) {
>    auto toMappedAddr = [&](uint64_t VAddr) -> const uint8_t * {
> -    const Elf_Phdr *const *I = std::upper_bound(
> -        LoadSegments.begin(), LoadSegments.end(), VAddr, compareAddr<ELFT>);
> +    const Elf_Phdr *const *I =
> +        std::upper_bound(LoadSegments.begin(), LoadSegments.end(), VAddr,
> +                         [](uint64_t VAddr, const Elf_Phdr_Impl<ELFT> *Phdr) {
> +                           return VAddr < Phdr->p_vaddr;
> +                         });

I would have a small preference to making "make compareAddr a lambda at
its only use" an independent patch.


LGTM with that.

Thanks,
Rafael