[PATCH] D38783: [CGP] Fix the detection of trivial case for addressing mode

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 14:47:51 PDT 2017


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

This logic certainly looks cleaner.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:2730
 
-  // AddrModes with a base reg or gv where the reg/gv is just the original
-  // value are trivial.
+  // AddrModes with a baseReg or gv where the reg/gv is alone field are trivial.
   bool isTrivial() {
----------------
is alone field -> is the only populated field


https://reviews.llvm.org/D38783





More information about the llvm-commits mailing list