[PATCH] D38907: Give .note.gnu.build-id section alignment 4

[Jake Ehrlich via llvm-commits]

I'll add tests for the behavior as is, it's simple to change if we decide
on a different behavior.

Best,
Jake


On Mon, Oct 30, 2017 at 1:46 PM Rui Ueyama via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> I'm ok with either 4 or 8, but 1 is just wrong. :) So it needs submitting.
>
> On Mon, Oct 30, 2017 at 1:31 PM, Roland McGrath via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> I'm not actively doing anything with it.  Perhaps Jake would like to
>> follow through.
>>
>> Despite what the so-called "spec" says, in actual fact, the note header's
>> fields are 32-bit in both ELFCLASS32 and ELFCLASS64 and the expected
>> alignment is always 4.
>>
>> On Mon, Oct 30, 2017 at 11:22 AM, Rafael Avila de Espindola <
>> rafael.espindola at gmail.com> wrote:
>>
>>> Is anyone still working on this?
>>>
>>> It should have a testcase and probably align to 8 on 64 bits, but change
>>> is a good one.
>>>
>>> Cheers,
>>> Rafael
>>>
>>> George Rimar via Phabricator via llvm-commits
>>> <llvm-commits at lists.llvm.org> writes:
>>>
>>> > grimar added a comment.
>>> >
>>> > Probably needs testcase ?
>>> >
>>> >
>>> > Repository:
>>> >   rL LLVM
>>> >
>>> > https://reviews.llvm.org/D38907
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > llvm-commits mailing list
>>> > llvm-commits at lists.llvm.org
>>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171030/994aaaf0/attachment.html>