[PATCH] D38494: [SCEV] Handling for ICmp occuring in the evolution chain.

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added a comment.

In https://reviews.llvm.org/D38494#910421, @junryoungju wrote:

> :( that I commented didn't reviewed. this is why I wanted to make other reversion.


Are you saying that you had made the same comments as I did above?  If so, that wasn't clear from what you wrote.  You can help authors by:

- Adding inline comments instead of a top level comment, knowing which part of the patch you're referring to helps comprehension
- Being specific; instead of saying "this is very general" say "use `cast` instead of `switch`"


https://reviews.llvm.org/D38494