[PATCH] D39385: [BranchProbabilityInfo] Handle irreducible loops.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 10:45:03 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Analysis/BranchProbabilityInfo.cpp:450
+  // Consider any block that is an entry point to the SCC as a header.
+  auto isSCCHeader = [&](const BasicBlock *BB) {
+    assert(getSCCNum(BB) == SccNum);
----------------
Nit: It is probably better to change this lambda into a static function and move the body out to make the caller function body look cleaner.


https://reviews.llvm.org/D39385





More information about the llvm-commits mailing list