[compiler-rt] r316930 - Fix clang warnings in winasan code

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 30 10:26:57 PDT 2017


Author: rnk
Date: Mon Oct 30 10:26:57 2017
New Revision: 316930

URL: http://llvm.org/viewvc/llvm-project?rev=316930&view=rev
Log:
Fix clang warnings in winasan code

There are two instances of -Wcast-qual and one of -Wsign-compare.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc?rev=316930&r1=316929&r2=316930&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc Mon Oct 30 10:26:57 2017
@@ -379,7 +379,7 @@ struct ModuleInfo {
 
 #if !SANITIZER_GO
 int CompareModulesBase(const void *pl, const void *pr) {
-  const ModuleInfo *l = (ModuleInfo *)pl, *r = (ModuleInfo *)pr;
+  const ModuleInfo *l = (const ModuleInfo *)pl, *r = (const ModuleInfo *)pr;
   if (l->base_address < r->base_address)
     return -1;
   return l->base_address > r->base_address;
@@ -794,7 +794,7 @@ void BufferedStackTrace::SlowUnwindStack
   // FIXME: Compare with StackWalk64.
   // FIXME: Look at LLVMUnhandledExceptionFilter in Signals.inc
   size = CaptureStackBackTrace(1, Min(max_depth, kStackTraceMax),
-                               (void**)trace, 0);
+                               (void **)&trace_buffer[0], 0);
   if (size == 0)
     return;
 
@@ -917,7 +917,7 @@ bool IsAccessibleMemoryRange(uptr beg, u
 }
 
 bool SignalContext::IsStackOverflow() const {
-  return GetType() == EXCEPTION_STACK_OVERFLOW;
+  return (DWORD)GetType() == EXCEPTION_STACK_OVERFLOW;
 }
 
 void SignalContext::InitPcSpBp() {




More information about the llvm-commits mailing list