[PATCH] D38313: [InstCombine] Introducing Pattern Instruction Combine plug-in into InstCombine pass

[Zvi Rackover via Phabricator via llvm-commits]

zvi added a comment.

I know you decided to move this to a new pass, but here's a couple of more comments that will be relevant.



================
Comment at: test/Transforms/InstCombine/trunc_pattern.ll:13
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;; These tests check cases where expression dag dominated by trunc instruction
+;; contains instruction other than {zext, sext, trunc} has more than one usage.
----------------
dominated -> post-dominated


================
Comment at: test/Transforms/InstCombine/trunc_pattern.ll:18
+define void @multi_uses(i32 %X) {
+; CHECK-LABEL: @multi_uses(
+; CHECK-NEXT:    [[A1:%.*]] = zext i32 [[X:%.*]] to i64
----------------
May a nitpick of mine, but i find it easier to follow the check's when they arer right above the related sequence of instructions. Another option is to be break down to multiple functions.


https://reviews.llvm.org/D38313