[PATCH] D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a comment.

The issue is that std::sort is insufficient with properlyDominates() as comparator.
So, I have to propose to get rid of std::sort there.

Test code: https://gist.github.com/chapuni/9c5659610f5cd3c0933708bd43f32cdb

Although I am not special to vectorizer, I would like to fix my issue. See,
http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/459 (Applied this)
http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/460 (Reverted)

Is it inefficient to use RPOT there? I think better than sorting.


Repository:
  rL LLVM

https://reviews.llvm.org/D38586