[llvm] r316851 - [X86] Remove invalid code from LowerVSELECT.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 28 16:10:13 PDT 2017


Author: ctopper
Date: Sat Oct 28 16:10:13 2017
New Revision: 316851

URL: http://llvm.org/viewvc/llvm-project?rev=316851&view=rev
Log:
[X86] Remove invalid code from LowerVSELECT.

This code attempted to say that v8i16/v16i16 VSELECT is legal if BWI and VLX are enabled, but the only way we could reach this point is if the condition was not a vXi1 type. Which means it really wasn't legal.

We don't have any tests that exercise this code. So I'm hoping it wasn't really reachable.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=316851&r1=316850&r2=316851&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sat Oct 28 16:10:13 2017
@@ -14232,10 +14232,6 @@ SDValue X86TargetLowering::LowerVSELECT(
 
   case MVT::v8i16:
   case MVT::v16i16:
-    // AVX-512 BWI and VLX features support VSELECT with i16 elements.
-    if (Subtarget.hasBWI() && Subtarget.hasVLX())
-      return Op;
-
     // FIXME: We should custom lower this by fixing the condition and using i8
     // blends.
     return SDValue();




More information about the llvm-commits mailing list