[PATCH] D39028: Irreducible loop metadata for more accurate block frequency under PGO.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi added inline comments.


================
Comment at: include/llvm/Analysis/BlockFrequencyInfoImpl.h:1164
+      if (!HeaderWeight)
+        continue;
+      DEBUG(dbgs() << getBlockName(HeaderNode)
----------------
davidxl wrote:
> can just break here.
I tried it, turned out it needs to be a continue, because we still need the "IsIrrLoopHeader" (see line 1161 above) to be fully populated so that the PGO annotate pass can see which blocks are the headers and annotate accordingly (no headers have annotations before the PGO annotate pass, obviously.)


https://reviews.llvm.org/D39028