[PATCH] D39340: Modifying reassociate for improved CSE

escha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 12:24:41 PDT 2017


escha added a comment.

In https://reviews.llvm.org/D39340#909644, @dberlin wrote:

> This seems very similar to what n-ary reassociate wants to do, I'd like to understand why we shouldn't do it there?
>  (where it seems to fit perfectly)


Yeah, actually, I don't quite understand what N-ary reassociate *is* compared to this. One thing I do know about it is that it uses SCEV, which completely rules it out for floating point, which is the main thing I care about. Does it handle the integer case here?


Repository:
  rL LLVM

https://reviews.llvm.org/D39340





More information about the llvm-commits mailing list