[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 10:47:41 PDT 2017


ruiu added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:80-83
+  DwarfLine->getOrParseLineTable(LineData, 0,
+                                 Dwarf.getNumCompileUnits() > 0
+                                     ? Dwarf.getCompileUnitAtIndex(0)
+                                     : nullptr);
----------------
I don't fully understand this change, but it seems like if it was working before, `Dwarf.getNumCompileUnits() >0` is guaranteed, no?


https://reviews.llvm.org/D33155





More information about the llvm-commits mailing list