[PATCH] D39028: Irreducible loop metadata for more accurate block frequency under PGO.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: include/llvm/Analysis/BlockFrequencyInfoImpl.h:1164
+      if (!HeaderWeight)
+        continue;
+      DEBUG(dbgs() << getBlockName(HeaderNode)
----------------
can just break here.


================
Comment at: test/Transforms/PGOProfile/irreducible.ll:1
+; RUN: opt < %s -pgo-instr-gen -S | FileCheck %s --check-prefix=GEN
+; RUN: opt < %s -passes=pgo-instr-gen -S | FileCheck %s --check-prefix=GEN
----------------
The profile generate tests do not seem to be relevant, can be removed.


https://reviews.llvm.org/D39028