[PATCH] D38631: [SimplifyCFG] use pass options and remove the latesimplifycfg pass

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: include/llvm/Transforms/Scalar.h:263
+    bool ConvertSwitch = false, bool KeepLoops = true,
+    std::function<bool(const Function &)> Ftor = nullptr);
 
----------------
bmakam wrote:
> We still pass boolean and values to createCFGSimplificationPass(1, false, false, true) Don't we need builder API here as well?
This is only used by the legacy PM unless I'm not seeing it correctly. Fixing this will require more futzing, possibly adding includes for the header or moving the struct definition from its current location. So I was hoping that we'd let that go given that the new PM seems relatively close to becoming default.


https://reviews.llvm.org/D38631