[PATCH] D39294: [llvm-dwarfdump] - Teach verifier to report broken DWARF expressions.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Adrian, Jonas, thank you for review !



================
Comment at: test/tools/llvm-dwarfdump/X86/verify_broken_exprloc.s:12
+# VERIFY:      DW_TAG_GNU_call_site_parameter
+# VERIFY-NEXT:   DW_AT_location    (decoding error.)
+
----------------
aprantl wrote:
> grimar wrote:
> > aprantl wrote:
> > > where does the `.` after error come from? it looks out of place. Perhaps `<decoding error>` would be better?
> > `.` comes from https://github.com/llvm-mirror/llvm/blob/master/lib/DebugInfo/DWARF/DWARFExpression.cpp#L224.
> > 
> > It does not seem this message was ever tested before, so I removed the dot. 
> > 
> > `<decoding error>` looks better for me, but I would not change `()` to `<>` 
> > in this patch as it comes from some different place and probably should break a lot of tests, 
> > so looks should be done as separate change (if should).
> This is obviously not super important, but I thought of
> `DW_AT_location    (<decoding error>)`
> The <> is meant to "escape" the error message and make it look different from an actual value.
Ah, there is no problems to do that in this patch then I believe,
I'll change to `(<decoding error>)` before commit.


https://reviews.llvm.org/D39294