[PATCH] D39345: SCEV: preserve debug information attached to PHI nodes.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 15:15:35 PDT 2017


hfinkel added inline comments.


================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:1215
+  // Save the original PHI node so we can copy over its debug info.
+  PHINode *OldPN = L->getCanonicalInductionVariable();
+ 
----------------
How do you know that the AddRec being expanded here is equivalent to a canonical induction variable? That's only true if we're expanding '{0,+,1}', right?

Does calling SE.getSCEVValues(Normalized) also find the original PHI node?



https://reviews.llvm.org/D39345





More information about the llvm-commits mailing list