[PATCH] D39334: [Driver] Add Scudo as a possible -fsanitize= option

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 13:08:53 PDT 2017


alekseyshl added inline comments.


================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:575
       }
     }
+    if (SanArgs.needsScudoRt())
----------------
cryptoad wrote:
> alekseyshl wrote:
> > Minor: add an empty line here or remove the one you added before needsUbsanRt.
> Just to make sure: there are currently no empty line before needsUbsanRt (it was removed for consistency).
> So currently there is 0 empty line: would you rather 1 on each side of needsUbsanRt?
Indeed! Please ignore.


https://reviews.llvm.org/D39334





More information about the llvm-commits mailing list