[PATCH] D39304: [IR] redefine 'reassoc' fast-math-flag and add 'trans' fast-math-flag

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In https://reviews.llvm.org/D39304#908340, @wristow wrote:

> In https://reviews.llvm.org/D39304#907880, @spatel wrote:
>
> > ...
> >  This might suggest that we should split 'trans' into its own small follow-up patch. That would also allow the unsafe TODO fixes to proceed independently of 'trans' in case that takes longer to sort out. Let me know if splitting this patch up seems better.
>
>
> I'd like to see the new enumerations of the FastMathFlags bits all defined in one patch.  So removing 'UnsafeAlgebra', and adding 'AllowReassoc' and 'AllowTrans' (along with all the changes required since 'UnsafeAlgebra' can no longer be referenced) in the first patch, is my preference.  (As an aside, probably 'AllowTrans' will be changed to something like 'AllowMathLib', due to other discussions here.)


Makes sense to me as well.


https://reviews.llvm.org/D39304