[PATCH] D39334: [Driver] Add Scudo as a possible -fsanitize= option

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/Driver/SanitizerArgs.cpp:386
+      std::make_pair(Scudo, Thread), std::make_pair(Scudo, Memory),
+      std::make_pair(Scudo, KernelAddress), std::make_pair(Scudo, Undefined) };
   for (auto G : IncompatibleGroups) {
----------------
It's a pair of SanitizerMasks, why not add std::make_pair(Scudo, Address | Leak | Thread | Memory | KernelAddress | Undefined)?


================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:575
       }
     }
+    if (SanArgs.needsScudoRt())
----------------
Minor: add an empty line here or remove the one you added before needsUbsanRt.


================
Comment at: test/Driver/fsanitize.c:622
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=scudo,undefined %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SCUDO-UBSAN
+// CHECK-SCUDO-UBSAN: invalid argument '-fsanitize=scudo' not allowed with '-fsanitize=undefined'
----------------
Why checking just these two combinations?


https://reviews.llvm.org/D39334