[PATCH] D38944: [GVN] Handle removal of first implicit CF instruction correctly

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added inline comments.


================
Comment at: lib/Transforms/Scalar/GVN.cpp:2109
+      DEBUG(verifyRemoved(I));
+      if (!InvalidateImplicitCF &&
+          FirstImplicitControlFlowInsts.lookup(I->getParent()) == I)
----------------
reames wrote:
> This can be written as:
> InvalidateImplicitCF |= new_condition;
```|= wouldn't short circuit however, since it's bitwise and not logical
So it would have to be InvalidateImplicitCF = x || y



https://reviews.llvm.org/D38944