[PATCH] D38037: [InstCombine] Compacting or instructions whose operands are shift instructions

[Davide Italiano via Phabricator via llvm-commits]

davide requested changes to this revision.
davide added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2291
+  {
+    BinaryOperator *BinOp00, *BinOp01, *BinOp10, *BinOp11;
+    ConstantInt *C00, *C01, *C10, *C11;
----------------
IMHO, this got a little too far.
FWIW, matchers should look just a few instructions at the time and not whole trees.
Is there a way to split this up or do differently?
I really don't want reassociate to become the next instcombine.


https://reviews.llvm.org/D38037