[PATCH] D39295: [LSV] Skip all non-byte sizes, not only less than eight bits

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 06:42:59 PDT 2017


bjope added inline comments.


================
Comment at: include/llvm/IR/DataLayout.h:382-385
+  bool isByteSized(Type *Ty) const {
+    uint64_t TySize = getTypeSizeInBits(Ty);
+    return (TySize % 8) == 0;
+  }
----------------
arsenm wrote:
> This should probably be a separate patch
Ok, I'll skip doing the refactoring in this patch (even though my hidden agenda was to move the byte size dependency to DataLayout, enhancing readability and at the same time making it easier for out-of-tree targets with different byte sizes to simply patch DataLayout).


https://reviews.llvm.org/D39295





More information about the llvm-commits mailing list