[PATCH] D39264: [GISel]: Make the combiner check if shifts are legal before creating them

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 02:58:57 PDT 2017


rovka added inline comments.


================
Comment at: llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h:98
       unsigned SizeDiff = DstTy.getSizeInBits() - SExtSrcTy.getSizeInBits();
       auto SizeDiffMIB = Builder.buildConstant(DstTy, SizeDiff);
       unsigned TruncSrcReg = DefMI->getOperand(1).getReg();
----------------
You forgot this G_CONSTANT :)


Repository:
  rL LLVM

https://reviews.llvm.org/D39264





More information about the llvm-commits mailing list