[PATCH] D39245: [ADT] Shuffle containers before sorting to uncover non-deterministic behavior

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

I don't really like the ever growing set of configuration macros here.

I would much prefer we have one ABI-breaking check macro and just use that for everything here...



================
Comment at: include/llvm/ADT/STLExtras.h:792
+#if LLVM_ENABLE_SHUFFLE_BEFORE_SORT
+  std::random_shuffle(Start, End);
+#endif
----------------
This was deprecated in C++14, I think you want std::shuffle now with a PRNG parameter.


Repository:
  rL LLVM

https://reviews.llvm.org/D39245