[compiler-rt] r316620 - [scudo] Remove comment about security of the 32-bit allocator

Kostya Kortchinsky via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 15:00:26 PDT 2017


Author: cryptoad
Date: Wed Oct 25 15:00:26 2017
New Revision: 316620

URL: http://llvm.org/viewvc/llvm-project?rev=316620&view=rev
Log:
[scudo] Remove comment about security of the 32-bit allocator

Summary:
The 32-bit allocator is now on par with the 64-bit in terms of security (chunks
randomization is done, batches separation is done).

Unless objection, the comment can go away.

Reviewers: alekseyshl

Reviewed By: alekseyshl

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D39303

Modified:
    compiler-rt/trunk/lib/scudo/scudo_allocator.h

Modified: compiler-rt/trunk/lib/scudo/scudo_allocator.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/scudo/scudo_allocator.h?rev=316620&r1=316619&r2=316620&view=diff
==============================================================================
--- compiler-rt/trunk/lib/scudo/scudo_allocator.h (original)
+++ compiler-rt/trunk/lib/scudo/scudo_allocator.h Wed Oct 25 15:00:26 2017
@@ -77,9 +77,6 @@ struct AP64 {
 };
 typedef SizeClassAllocator64<AP64> PrimaryAllocator;
 #else
-// Currently, the 32-bit Sanitizer allocator has not yet benefited from all the
-// security improvements brought to the 64-bit one. This makes the 32-bit
-// version of Scudo slightly less toughened.
 static const uptr NumRegions = SANITIZER_MMAP_RANGE_SIZE >> RegionSizeLog;
 # if SANITIZER_WORDSIZE == 32
 typedef FlatByteMap<NumRegions> ByteMap;




More information about the llvm-commits mailing list