[llvm] r316615 - [SCEV] Fix an assertion failure in the max backedge taken count

[Sanjoy Das via llvm-commits]

Author: sanjoy
Date: Wed Oct 25 14:41:00 2017
New Revision: 316615

URL: http://llvm.org/viewvc/llvm-project?rev=316615&view=rev
Log:
[SCEV] Fix an assertion failure in the max backedge taken count

Max backedge taken count is always expected to be a constant; and this is
usually true by construction -- it is a SCEV expression with constant inputs.
However, if the max backedge expression ends up being computed to be a udiv with
a constant zero denominator[0], SCEV does not fold the result to a constant
since there is no constant it can fold it to (SCEV has no representation for
"infinity" or "undef").

However, in computeMaxBECountForLT we already know the denominator is positive,
and thus at least 1; and we can use this fact to avoid dividing by zero.

[0]: We can end up with a constant zero denominator if the signed range of the
stride is more precise than the unsigned range.

Added:
    llvm/trunk/test/Analysis/ScalarEvolution/max-be-count-not-constant.ll
Modified:
    llvm/trunk/lib/Analysis/ScalarEvolution.cpp

Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=316615&r1=316614&r2=316615&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)
+++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Wed Oct 25 14:41:00 2017
@@ -9703,17 +9703,16 @@ const SCEV *ScalarEvolution::computeMaxB
   APInt MinStart =
       IsSigned ? getSignedRangeMin(Start) : getUnsignedRangeMin(Start);
 
-  APInt StrideForMaxBECount;
+  APInt StrideForMaxBECount =
+      IsSigned ? getSignedRangeMin(Stride) : getUnsignedRangeMin(Stride);
 
-  bool PositiveStride = isKnownPositive(Stride);
-  if (PositiveStride)
-    StrideForMaxBECount =
-        IsSigned ? getSignedRangeMin(Stride) : getUnsignedRangeMin(Stride);
-  else
-    // Using a stride of 1 is safe when computing max backedge taken count for a
-    // loop with unknown stride, since the precondition for this function is
-    // that it is positive.
-    StrideForMaxBECount = APInt(BitWidth, 1, IsSigned);
+  // We already know that the stride is positive, so we paper over conservatism
+  // in our range computation by forcing StrideForMaxBECount to be at least one.
+  // In theory this is unnecessary, but we expect MaxBECount to be a
+  // SCEVConstant, and (udiv <constant> 0) is not constant folded by SCEV (there
+  // is nothing to constant fold it to).
+  APInt One(BitWidth, 1, IsSigned);
+  StrideForMaxBECount = APIntOps::smax(One, StrideForMaxBECount);
 
   APInt MaxValue = IsSigned ? APInt::getSignedMaxValue(BitWidth)
                             : APInt::getMaxValue(BitWidth);

Added: llvm/trunk/test/Analysis/ScalarEvolution/max-be-count-not-constant.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/ScalarEvolution/max-be-count-not-constant.ll?rev=316615&view=auto
==============================================================================
--- llvm/trunk/test/Analysis/ScalarEvolution/max-be-count-not-constant.ll (added)
+++ llvm/trunk/test/Analysis/ScalarEvolution/max-be-count-not-constant.ll Wed Oct 25 14:41:00 2017
@@ -0,0 +1,26 @@
+; RUN: opt < %s -analyze -scalar-evolution | FileCheck %s
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+; Previously in this case the max backedge count would be computed as 1/0, which
+; is correct but undesirable.  It would also not fold as a constant, tripping
+; asserts in SCEV.
+
+define void @pluto(i32 %arg) {
+; CHECK-LABEL: Classifying expressions for: @pluto
+; CHECK: Loop %bb2: max backedge-taken count is 2
+bb:
+  %tmp = ashr i32 %arg, 31
+  %tmp1 = add nsw i32 %tmp, 2
+  br label %bb2
+
+bb2:                                              ; preds = %bb2, %bb
+  %tmp3 = phi i32 [ 0, %bb ], [ %tmp4, %bb2 ]
+  %tmp4 = add nuw nsw i32 %tmp1, %tmp3
+  %tmp5 = icmp ult i32 %tmp4, 2
+  br i1 %tmp5, label %bb2, label %bb6
+
+bb6:                                              ; preds = %bb2
+  ret void
+}