[llvm] r316604 - Hexagon: Fold a single-use textual header into its use

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 12:58:18 PDT 2017


All the "Dep" files are machine-generated. This patch will introduce 
conflicts with our local repo (where we need to maintain this 
structure). Was this change necessary for anything? I'd prefer to revert it.

-Krzysztof

On 10/25/2017 2:52 PM, David Blaikie via llvm-commits wrote:
> Author: dblaikie
> Date: Wed Oct 25 12:52:21 2017
> New Revision: 316604
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=316604&view=rev
> Log:
> Hexagon: Fold a single-use textual header into its use
> 
> Removed:
>      llvm/trunk/lib/Target/Hexagon/HexagonDepDecoders.h
> Modified:
>      llvm/trunk/lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp
> 
> Modified: llvm/trunk/lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp?rev=316604&r1=316603&r2=316604&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp (original)
> +++ llvm/trunk/lib/Target/Hexagon/Disassembler/HexagonDisassembler.cpp Wed Oct 25 12:52:21 2017
> @@ -138,24 +138,65 @@ static DecodeStatus unsignedImmDecoder(M
>                                          uint64_t Address, const void *Decoder);
>   static DecodeStatus s32_0ImmDecoder(MCInst &MI, unsigned tmp,
>                                       uint64_t /*Address*/, const void *Decoder);
> -static DecodeStatus s8_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                 const void *Decoder);
> -static DecodeStatus s6_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                   const void *Decoder);
> -static DecodeStatus s4_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                   const void *Decoder);
> -static DecodeStatus s4_1ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                   const void *Decoder);
> -static DecodeStatus s4_2ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                   const void *Decoder);
> -static DecodeStatus s4_3ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                   const void *Decoder);
> -static DecodeStatus s3_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
> -                                   const void *Decoder);
>   static DecodeStatus brtargetDecoder(MCInst &MI, unsigned tmp, uint64_t Address,
>                                       const void *Decoder);
>   
> -#include "HexagonDepDecoders.h"
> +static DecodeStatus s4_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<4>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s29_3ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                    const void *Decoder) {
> +  signedDecoder<14>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s8_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<8>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s4_3ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<7>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s31_1ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                    const void *Decoder) {
> +  signedDecoder<12>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s3_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<3>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s30_2ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                    const void *Decoder) {
> +  signedDecoder<13>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s6_0ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<6>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s6_3ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<9>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s4_1ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<5>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +static DecodeStatus s4_2ImmDecoder(MCInst &MI, unsigned tmp, uint64_t,
> +                                   const void *Decoder) {
> +  signedDecoder<6>(MI, tmp, Decoder);
> +  return MCDisassembler::Success;
> +}
> +
>   #include "HexagonGenDisassemblerTables.inc"
>   
>   static MCDisassembler *createHexagonDisassembler(const Target &T,
> 
> Removed: llvm/trunk/lib/Target/Hexagon/HexagonDepDecoders.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonDepDecoders.h?rev=316603&view=auto
> ==============================================================================
> --- llvm/trunk/lib/Target/Hexagon/HexagonDepDecoders.h (original)
> +++ llvm/trunk/lib/Target/Hexagon/HexagonDepDecoders.h (removed)
> @@ -1,64 +0,0 @@
> -//===--- HexagonDepDecoders.h ---------------------------------------------===//
> -//
> -//                     The LLVM Compiler Infrastructure
> -//
> -// This file is distributed under the University of Illinois Open Source
> -// License. See LICENSE.TXT for details.
> -//
> -//===----------------------------------------------------------------------===//
> -
> -static DecodeStatus s4_0ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<4>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s29_3ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<14>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s8_0ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<8>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s4_3ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<7>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s31_1ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<12>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s3_0ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<3>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s30_2ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<13>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s6_0ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<6>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s6_3ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<9>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s4_1ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<5>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> -static DecodeStatus s4_2ImmDecoder(MCInst &MI, unsigned tmp,
> -    uint64_t, const void *Decoder) {
> -  signedDecoder<6>(MI, tmp, Decoder);
> -  return MCDisassembler::Success;
> -}
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation


More information about the llvm-commits mailing list