[PATCH] D39289: [SelectionDAG] Support 'bit preserving' floating points bitcasts on computeKnownBits/ComputeNumSignBits

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 11:26:21 PDT 2017


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2233
+    if (!(SubVT.isInteger() ||
+          (SubVT.isFloatingPoint() && TLI->hasBitPreservingFPLogic(SubVT))))
       break;
----------------
Not sure why you're checking hasBitPreservingFPLogic; from its documentation, it specifically applies to the behavior of FABS/FNEG.  BITCAST should always preserve all bits.


Repository:
  rL LLVM

https://reviews.llvm.org/D39289





More information about the llvm-commits mailing list