[PATCH] D39263: [support] remove tautological comparison in Support/Windows/Path.inc

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 08:29:24 PDT 2017


amccarth added a comment.

Zach is correct about the overly large reservation in the file mapping and we should fix that too.



================
Comment at: llvm/lib/Support/Windows/Path.inc:726
-  if (Size > std::numeric_limits<SIZE_T>::max())
-    return make_error_code(errc::invalid_argument);
-
----------------
I assume someone was originally worried that `SIZE_T` would be 32 bits wide in a 32-bit build but somehow believed `std::size_t` (which is the type of Size) could still somehow be larger than that.  Ain't gonna happen.


https://reviews.llvm.org/D39263





More information about the llvm-commits mailing list