[PATCH] D38319: [ELF] - Teach ICF to take FDEs into account when doing code folding.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/EhFrame.cpp:67
 
+static bool equalsFde(EhSectionPiece *A, EhSectionPiece *B) {
+  // We want to compare FDEs contents, for that we want to ignore
----------------
grimar wrote:
> ruiu wrote:
> > I doubt if this is correct because this function seems to compare contents only byte-by-byte. You need to handle relocations right?
> I have already answered the same question here:
> https://reviews.llvm.org/D38319#inline-335138
That URL just jumps to the top of the page to me.


https://reviews.llvm.org/D38319